[FFmpeg-devel] [RFC] Split libavformat

[Diego Biurrun]

On Thu, Nov 22, 2007 at 10:03:20AM +0100, Luca Abeni wrote:
> Luca Abeni wrote:
>> Diego Biurrun wrote:
>> [...]
>>>> +    REGISTER_INDEVOUTDEV (AUDIO_BEOS, audio_beos);
>>> Maybe INOUTDEV would sound better.
>> Ok. configure does not seem to like it; I am investigating the reason
>> and I hope to fix this soon.
>
> ...And this is the new patch. I hope I addressed all the comments.
> I even went one step further and changed all the *_muxer and *_demuxer
> structure names to *_outdev and *_indev (so the patch is bigger, now).
> If this is wrong, I will remove this last change.
>
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ ffmpeg/libavdevice/avdevice.h	2007-11-22 08:51:21.000000000 +0100
> @@ -0,0 +1,33 @@
> +
> + * Initialize libavdevice and register all the input and output devices.
> + * \warning This function is not thread safe

missing period

> --- ffmpeg.orig/configure	2007-11-22 08:45:38.000000000 +0100
> +++ ffmpeg/configure	2007-11-22 09:53:52.000000000 +0100
> @@ -920,9 +920,11 @@
>  BSF_LIST=`sed -n 's/^[^#]*BSF.*(.*, *\(.*\)).*/\1_bsf/p' "$source_path/libavcodec/allcodecs.c"`
>  MUXER_LIST=`sed -n 's/^[^#]*_MUX.*(.*, *\(.*\)).*/\1_muxer/p' "$source_path/libavformat/allformats.c"`
>  DEMUXER_LIST=`sed -n 's/^[^#]*DEMUX.*(.*, *\(.*\)).*/\1_demuxer/p' "$source_path/libavformat/allformats.c"`
> +IN_DEV_LIST=`sed -n 's/^[^#]*_IN.*(.*, *\(.*\)).*/\1_indev/p' "$source_path/libavdevice/alldevices.c"`
> +OUT_DEV_LIST=`sed -n 's/^[^#]*OUTDEV.*(.*, *\(.*\)).*/\1_outdev/p' "$source_path/libavdevice/alldevices.c"`

INDEV.*

Also, it's inconsistent to call it IN_DEV here and INDEV everywhere
else.

> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ ffmpeg/libavdevice/alldevices.c	2007-11-22 09:47:37.000000000 +0100
> @@ -0,0 +1,52 @@
> +/*
> + * Register all the grabbing devices

missing period

The rest looks OK.

Diego