[FFmpeg-devel] [PATCH] make mpeg4 parser set has_b_frames

Diego Biurrun diego
Thu Nov 22 10:12:48 CET 2007


On Thu, Nov 22, 2007 at 02:09:11AM +0100, elupus wrote:
> > On Thu, Nov 22, 2007 at 12:45:01AM +0100, elupus wrote:
> > >
> > > --- libavcodec/mpeg4video_parser.c (revision 11070)
> > > +++ libavcodec/mpeg4video_parser.c (working copy)
> > > @@ -85,6 +85,7 @@
> > >     if (s->width) {
> > >         avcodec_set_dimensions(avctx, s->width, s->height);
> > >     }
> > > +    avctx->has_b_frames = !s->low_delay;
> > >     s1->pict_type= s->pict_type;
> > >     pc->first_picture = 0;
> > >     return ret;
> >
> > and stop sending mangled patches!
> > besides that this is not a valid patch (and i wont bother doing your work
> > fixing that), it would likely be ok
> 
> That's fine, if I could figure why they are mangled it would hopefully be 
> easy to fix.
>  http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071122/e7d65bd6/attachment.txti can't see anything mangled in the patch. Aleast not the invalid offset ofthe line you are getting.It was generated with svn diff without being touched manually. I assume itcould have something todo with "An embedded and charset-unspecified text wasscrubbed..." that mailman writes. I'm posting through gmane newsgroup, soprobably some oddness with my client and them.

I think you keep

1) inserting tabs,
2) use shitty MS mail clients.

What do you expect?

Diego




More information about the ffmpeg-devel mailing list