[FFmpeg-devel] [PATCH] move wmv2 encoder to its own file

[Diego Biurrun]

On Tue, Nov 13, 2007 at 01:13:09AM +0100, Diego Biurrun wrote:
> On Mon, Nov 12, 2007 at 12:36:36AM +0100, Aurelien Jacobs wrote:
> > Diego Biurrun wrote:
> > 
> > > Attached patch does $subject.  It compiles and passes regression tests.
> > > The only issue is that it duplicates the SKIP_TYPE_* definitions at the
> > > top of the file.  I could move these to a wmv2.h header file if this is
> > > preferred.
> > 
> > Not only you duplicate SKIP_TYPE_* but also struct Wmv2Context definition
> > and ff_wmv2_common_init().
> 
> Yes, thanks for noticing.
> 
> > Attached patch does a finer grained split (including splitting both
> > wmv2 enc and dec in their own file).
> 
> My plan was to split off wmv2dec afterwards to have smaller diffs.  I
> still vote for removing wmv2_encode_end first, if you wish to commit
> this in two steps, I don't know.  In any case, this bodes well, I'm
> looking forward to see it committed.

Aurelien, commit :)

Diego