[FFmpeg-devel] [Patch] adding 'dist' rule to makefiles

Diego Biurrun diego
Tue Nov 13 00:35:28 CET 2007


On Mon, Nov 12, 2007 at 04:49:24PM -0500, Ronald S. Bultje wrote:
> 
> On Nov 12, 2007 7:12 AM, Dejan Sakelsak <sakdean at gmail.com> wrote:
> 
> > generates a ffmpeg.tar.gz tarball in $(SRC_PATH)
> >
> > i hope, the patch will come handy and be applied.
> 
> As for the patch, a lot of stuff can be generalized in config.mak (make dist
> is copied 3 times, for example).

At a quick glance the current implementation is fairly ugly and rejected
due to messing up the formatting.

> More interesting would be a co-implementation of make distcheck on top
> of this (only for the top-level dir, fairly easy).

I see 'make test' there already.  What is the difference?

> Maybe here's some nice bone for Diego to bite in:

:)

> implement those two, be it with this patch or another, and I'll drop my
> autotools.patch, completely.

Heh, the last time around you claimed that your auto* version was
shorter than ours (quick reminder: it is not).

I'm all for automating things, but I think all of the advantages you
described are easier to achieve by a small shell script sitting outside
the FFmpeg source tree...

Diego




More information about the ffmpeg-devel mailing list