[FFmpeg-devel] [PATCH] Add the function libavcodec/utils.c:avcodec_type_string
Stefano Sabatini
stefano.sabatini-lala
Mon Nov 12 09:53:39 CET 2007
On date Friday 2007-11-09 15:26:22 +0100, Stefano Sabatini encoded:
> On date Friday 2007-11-09 11:34:25 +0100, Stefano Sabatini encoded:
> > On date Friday 2007-11-09 09:00:05 +0000, M?ns Rullg?rd encoded:
> [...]
> > > Why don't you declare the argument as type CodecType? That should
> > > make it abundantly clear what is expected.
> > >
> > > Also, why do you use snprintf() here, when av_strlcpy() would do just
> > > as well, or even simply returning the string constants.
> > [...]
> >
> > Yes, it looks like a simpler solution, which I prefer over the
> > previous ones.
Ping (resubmitting in the case it gets unnoticed).
Best regards.
--
Stefano Sabatini
Linux user number 337176 (see http://counter.li.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-avcodec-type-string-function-05.patch
Type: text/x-diff
Size: 1935 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071112/643774bb/attachment.patch>
More information about the ffmpeg-devel
mailing list