[FFmpeg-devel] [PATCH] Dump info for all streams (not just those known to be in a program)

[Wolfram Gloger]

Hi,

> That's code snippet isn't the problem.  The problem is the default
> case in the switch statement in the new_pes_av_stream() function.

Well those are sane defaults: if we don't know what it is, try mpeg.
Even when just choosing "stream copy" stream parameters (including
codec id) are later adjusted by the mpeg parser.  And if the stream
really is _not_ mpeg, the chance of this producing _wrong_ data,
rather than producing an error, are negligble IMHO.

> >> It's not user friendly to create unplayable files.
> >
> > I can't see how that could happen.
> 
> What????  It *HAS* happened.  There are lots of MPEG-TS files missing
> PSI created by broken DVB tools.

Oh, but these files are playable just fine.
Please be clear what you're criticising -- I thought you meant
the danger of creating something unplayable in ffmpeg through
wrong guesswork, which I agree would be a bad thing to do.

Can't we settle on "be liberal in what you accept, and strict in
what you generate"?  And just apply the patch?

Regards,
Wolfram.