[FFmpeg-devel] [PATCH] ogg muxer

[Justin Ruggles]

Baptiste Coudurier wrote:
> M?ns Rullg?rd wrote:
>> Rich Felker <dalias at aerifal.cx> writes:
>>
>>
>>> On Thu, Nov 01, 2007 at 03:27:05AM +0100, Michael Niedermayer wrote:
>>>
>>>> Hi
>>>>
>>>> On Thu, Nov 01, 2007 at 02:41:04AM +0100, Baptiste Coudurier wrote:
>>>> [...]
>>>>
>>>>>> you also might want to add ogg regression tests after this gets commited
>>>>> vorbis encoding tests seems disabled atm, any plan to fix them ?
>>>> well, no
>>>> cant you just store something else in it? anything, it doesnt matter just
>>> Nope, ogg only supports a limited set of codecs with their own spec
>>> for how to store them in ogg....
>>
>> Ogg can store FLAC, and we have a working FLAC encoder.
>>
> 
> Yes, here is another update with flac support. I tried using a switch,
> but in fact it duplicates extradata and extrada_size check in all cases.
> 
> Regression tests included.
> 
> I put flac codec by default, I would prefer to put vorbis but ... ok for
> everyone ?

Nice!  I'm not really a fan of Ogg/FLAC, but I'm still happy that it 
will be supported.  I never could get it working with the libogg muxer. 
  I'm sure it's possible, but I didn't have enough interest to keep trying.

Thank you!

-Justin