[FFmpeg-devel] R10953 broke MPEG decoding

Aurelien Jacobs aurel
Fri Nov 9 14:09:15 CET 2007


Reimar D?ffinger wrote:

> Hello,
> On Thu, Nov 08, 2007 at 09:55:40PM +0100, Aurelien Jacobs wrote:
> > Benoit Fouet wrote:
> > 
> > > Uoti Urpala wrote:
> > > > On Thu, 2007-11-08 at 14:13 +0100, Luca Abeni wrote:
> > > >   
> > > >> So, I guess it is a compiler or libc issue. I am on Ubuntu 7.04 (gcc 4.1.2 and
> > > >> glibc 2.5).
> > > >>     
> > > >
> > > > My guess is that you're on a 32-bit platform and he's on 64-bit; I'd
> > > > expect the bug in r10953 to be visible on the former but not on the
> > > > latter.
> > > > The error is the bad second argument to url_fseek.
> > > >
> > > >   
> > > 
> > > indeed, attached is a patch to fix it
> > 
> > Right.
> > Fixed in a simpler way (tested on 32 bits arch this time !).
> 
> Well, I personally wouldn't call it "simpler" but "much more
> obfuscated", but whatever, it's not my code.

I guess you are talking about the full rewrite by Mans. Not about
the simple fix I applied before...




More information about the ffmpeg-devel mailing list