[FFmpeg-devel] [PATCH] H264: Fix deblocking for first row in fields

[Michael Niedermayer]

Hi
On Wed, Nov 07, 2007 at 03:05:29PM -0500, Jeff Downs wrote:
> H264 PAFF implementation is missing a change to filter_mb_fast to 
> check for deblocking on the first row of a bottom field.  Without this 
> check, filter_mb_fast might be called for the first row, which (from what 
> I understand in a read of the existing code) is not appropriate.  In 
> particular, a run through valgrind will show that the access to 
> qscale_table[h->top_mb_xy] goes out of bounds (top_mb_xy is negative for 
> first row).
> 
> This augments the existing check to look for row 1 in bottom fields.
> 
> Benchmarks here with non-interlaced content showed no real speed impact 
> (overhead of the check), which is surprising to me; if anyone else wants 
> to check that, please feel free.

patch looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071108/8731eb4d/attachment.pgp>