[FFmpeg-devel] [PATCH] IPv6 support v.2

[Ronald S. Bultje]

Hi Luca,

On Nov 7, 2007 7:16 AM, Luca Abeni <lucabe72 at email.it> wrote:

> Ronald S. Bultje wrote:
> > Sure, Quite clearly, that will result in temporary lack of ipv6 support
> > until my new patches have been applied, is that OK?
>
> No, this is not what I meant... I was thinking about code reorganization
> only, without any change in the behaviour (so, without removing IPv6
> support).

[..]

> Now, udp_ipv6_set_remote_url() is very similar to the code in
> udp_set_remote_url()... This is an example of the code duplication I
> was referring to... Isn't this the code duplication you addressed in
> your patch?
> I think this kind of duplication can be removed without any change in
> the functionalities (so, without loosing IPv6 support).
>

Dropping either code path will result in:
- losing ipv6 support
or
- losing support for OSes that do not have ipv6

I'm OK with either, although I can't help but wonder if we're not just going
in circles to get my patches in.

As for the "why inetaddr_*() instead of just the ipv6- (-independent) code,
it's basically for legacy-support. FF also supports gcc 2.95, so... If you
want getaddrinfo() directly, go for it, but then why did the code paths
exist to begin with?

Ronald