[FFmpeg-devel] [PATCH] IPv6 support v.2
Wed Nov 7 16:02:30 CET 2007
first of all, I just committed the remaining part of your patch for
fixing ffserver and ffplay on macos. Can you try a checkout and confirm
if they now work for you?
Then, I am beginning to look at your other IPv6 support patches...
(WARNING: from this point, I am expressing my own opinions. If someone else
disagrees and is willing to review these patches and help to commit the IPv6
code, I am happy to step back).
IMHO, the first thing we need to do is to cleanup some code (for example,
in udp.c), so that your patches can be made smaller, easier to review, and
safer to apply.
For example, udp.c currently contains a lot of code duplication between
IPv6 and IPv4. I believe that removing this code duplication is the first
step. I see that your ffmpeg-ipv6-udp.patch removes some duplicated code:
Ronald S. Bultje wrote:
> This patch:
> - removes all duplicated CONFIG_IPV6 code in udp.c
> - ports the IPv4-code over to the new AVInetAddr API, thus making it a lot
> smaller, simpler and still IPv6-compatible
> Just in case people ask:
> - I made a minor change in udp_set_remote_url() to set port=-1 to port=0,
Can you split the patch and send the part which just removes duplicated code?
If yes, then I think that part (just reorganization of the code, without any
change in the behaviour) can be committed soon.
More information about the ffmpeg-devel