[FFmpeg-devel] [PATCH 0/6] split out functions in rmdec.c

[Ronald S. Bultje]

Hi,

On 11/6/07, Diego Biurrun <diego at biurrun.de> wrote:
>
> > +/**
> > + * Read the MDPR chunk, which contains stream-specific codec
> initialization
> > + * parameters.
> > + *
> > + * @param s context containing RMContext, ByteIOContext for stream
> reading
> > + * @param st stream that the MDPR chunk belongs to and where to store
> the
> > + *           parameters read from the chunk into
>
> I'd say "the stream".


Fixed.

Also, you should capitalize properly, same below.


What do you mean exactly? I looked at other function comments and they're
similar to this, at least in capitalization.

> + * @return 0 on success, errno codes on error
> > + */
> > +int ff_rm_read_mdpr_codecdata (AVFormatContext *s, AVStream *st);
> > +/**
>
> Geez, leave at least a single line of space between function
> declarations.
>
> > + * Parse one rm-stream packet from the input bytestream.
> > + *
> > + * @param s context containing RMContext, ByteIOContext for stream
> reading
> > + * @param st stream to which the packet to be read belongs
> > + * @param len length of the packet
>
> packet length
>
> > + * @param pkt packet location to store the parsed packet into
>
> s/into//
>
> > +/**
> > + * Retrieve one cached packet from the rm-context. The real contained
> can
>
> containeR
>
> > + * @param pkt location where to store the packet data into
>
> location to store the packet data


All fixed. New patch attached.

Ronald
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rmdec-no_static.patch
Type: application/octet-stream
Size: 3017 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071106/62c18570/attachment.obj>