[FFmpeg-devel] [PATCH 3/6] rmdec.c: ff_rm_retrieve_cache()

[Benoit Fouet]

Ronald S. Bultje wrote:
> Hi,
>
> On 11/5/07, Benoit Fouet <benoit.fouet at purplelabs.com> wrote:
>   
>> is this intentional ?
>>
>>     
>>> +    pkt->stream_index = st->index;
>>> -        pkt->stream_index = rm->audio_stream_num;
>>>
>>>       
>
>
> They are (always, as in you could assert() it) the same, because st is
> derived from s->streams[rm->audio_stream_num]. The advantage of this is that
> we don't need a pointer to the RMContext, and thus not to the
> AVFormatContext. I can also change it to take an extra AVFormatContext
> argument and then it would look as before.
>
>   

thanks
i don't think it's worth an extra argument (but it's not up to me to
decide ;) )

-- 
Ben
Purple Labs S.A.
www.purplelabs.com