[FFmpeg-devel] [PATCH] Fix some warnings in nut.c

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Sun, Nov 04, 2007 at 02:10:18PM +0100, Diego Biurrun wrote:
>> OK to apply the attached patch for
>> 
>> nut.c: In function ?ff_nut_sp_pos_cmp?:
>> nut.c:43: warning: suggest parentheses around + or - inside shift
>> nut.c:43: warning: suggest parentheses around + or - inside shift
>> nut.c: In function ?ff_nut_sp_pts_cmp?:
>> nut.c:47: warning: suggest parentheses around + or - inside shift
>> nut.c:47: warning: suggest parentheses around + or - inside shift
>> 
>> ?
>
> darn no! ive rejected this at least once already
> this is no warning fix it is just _WRONG_ the code just doesnt
> work anymore after this patch!

Would you be so kind as to add proper parentheses yourself?  It is
evidently not obvious how it's supposed to be, and if Diego's patch is
wrong, the use of whitespace is outright misleading.

-- 
M?ns Rullg?rd
mans at mansr.com