[FFmpeg-devel] [FFmpeg-cvslog] r10889 - trunk/libavcodec/allcodecs.c

[Michael Niedermayer]

On Thu, Nov 01, 2007 at 01:03:07AM +0200, Ismail D?nmez wrote:
> Thursday 01 November 2007 Tarihinde 00:55:46 yazm??t?:
> > michael wrote:
> > > Author: michael
> > > Date: Wed Oct 31 23:39:10 2007
> > > New Revision: 10889
> > >
> > > Log:
> > > prefer our native vorbis decoder over libvorbis
> >
> > It also affect encoder...
> > And libvorbis encoder is certainly preferred over the native one.
> >
> > > Modified:
> > >    trunk/libavcodec/allcodecs.c
> > >
> > > Modified: trunk/libavcodec/allcodecs.c
> > > =========================================================================
> > >===== --- trunk/libavcodec/allcodecs.c	(original)
> > > +++ trunk/libavcodec/allcodecs.c	Wed Oct 31 23:39:10 2007
> > > @@ -191,7 +191,6 @@ void avcodec_register_all(void)
> > >      REGISTER_ENCDEC  (LIBGSM_MS, libgsm_ms);
> > >      REGISTER_ENCODER (LIBMP3LAME, libmp3lame);
> > >      REGISTER_ENCODER (LIBTHEORA, libtheora);
> > > -    REGISTER_ENCDEC  (LIBVORBIS, libvorbis);
> > >      REGISTER_DECODER (MACE3, mace3);
> > >      REGISTER_DECODER (MACE6, mace6);
> > >      REGISTER_ENCDEC  (MP2, mp2);
> > > @@ -215,6 +214,7 @@ void avcodec_register_all(void)
> > >      REGISTER_ENCDEC  (WMAV1, wmav1);
> > >      REGISTER_ENCDEC  (WMAV2, wmav2);
> > >      REGISTER_DECODER (WS_SND1, ws_snd1);
> > > +    REGISTER_ENCDEC  (LIBVORBIS, libvorbis);
> >
> > I don't like this change very much...
> > Default ./configure will enable native vorbis and disable libvorbis.
> > If user intentionally enable libvorbis, that's probably because he
> > want to use it. Thus it should probably be preferred over vorbis.
> >
> > Oh, and the best way to fix this anyway is to drop support for
> > libvorbis decoding ;-)
> 
> Or remove non-working vorbis encoder.

or remove the libvorbis encoder, that way the vorbis encoder will soon be
fixed by volunteers ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071101/a5b06d81/attachment.pgp>