[FFmpeg-devel] [PATCH] h264: allocate PPS and SPS dynamically

[Michael Niedermayer]

Hi

On Mon, May 28, 2007 at 03:27:56PM +0200, Andreas ?man wrote:
> Hi
> 
> Michael Niedermayer wrote:
> > Hi
> > 
> > On Mon, May 28, 2007 at 03:00:19PM +0200, Andreas ?man wrote:
> >> Hi
> >>
> >> The following patch reduces sizeof(H264Context) from ~240kB to ~140kB.
> >> If only a few SPS and PPS are used (which i believe is most common)
> >> thus, it should save some memory footprint.
> > 
> > your code looks exploitable
> > 
> 
> Are you referring to that the "const int id" argument to
> alloc_parameter_set() is not unsigned?

yes

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070528/dac6d344/attachment.pgp>