[FFmpeg-devel] [PATCH] RoQ video encoder, take 2

[Diego Biurrun]

On Sun, May 27, 2007 at 12:21:03PM +0200, Vitor wrote:
> 
> Finally, to get rid of the YUV444 data, I reused some of the code from 
> the decoder. So I've splitted the decoder in a shared file and a decoder 
> specific file. I hope this is the preferred way of doing it.

Yes, this is the preferred way, but please submit this as a separate
patch, it's far easier to review this way.

> --- libavcodec/roqvideodec.c	(revision 0)
> +++ libavcodec/roqvideodec.c	(revision 0)
> @@ -0,0 +1,242 @@
> +/*
> + * Copyright (C) 2003 the ffmpeg project

This is not a legal entity.

> + * You should have received a copy of the GNU Lesser General Public
> + * License along with FFmpeg; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> + *
> + */

Nit: Useless empty line.

> --- libavcodec/roqvideo.h	(revision 0)
> +++ libavcodec/roqvideo.h	(revision 0)
> @@ -0,0 +1,96 @@
> +/*
> + * Copyright (C) 2003 the ffmpeg project

dito

Diego