[FFmpeg-devel] [PATCH] Split raw.c

Michael Niedermayer michaelni
Sat May 26 22:56:07 CEST 2007


On Wed, May 23, 2007 at 02:42:37PM +0200, Panagiotis Issaris wrote:
>  raw.h       |  200
> +----------------------------------------------------------
>  rawdec.c    |   91 +--------------------------
>  rawenc.c    |  178 ----------------------------------------------------
>  rawpixfmt.c |  171 +-------------------------------------------------
>  rawpixfmt.h |  202
> ++----------------------------------------------------------
>  5 files changed, 27 insertions(+), 815 deletions(-)

i think attaching the files after the split in addition to the diffs would be
usefull, as its very hard to see what is left in the files by just looking
at the diffs,
for example raw.h contains just a struct with 3 variables and a single
and ironically this struct is used just in rawdec.c ...

next the rawpixfmt.* code too seems just used by rawdec.c ...

so for a simple encoder/decoder split this is doing a few unneeded
things which just spread related code into several files and makes it
hard to read ...

and if some future change would benefit from having these things in
seperate files then such a future change could split them out ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070526/2d0137c8/attachment.pgp>

More information about the ffmpeg-devel mailing list