[FFmpeg-devel] Can't use libvorbis_encoder, due to name mismatch oggvorbis/libvorbis

[Michael Niedermayer]

Hi

On Thu, May 24, 2007 at 01:38:27PM +0200, Reimar Doeffinger wrote:
> Hello,
> On Thu, May 24, 2007 at 01:20:33PM +0200, Nicolas George wrote:
> [...]
> > It does not seem so: as far as I understand the code, it would be necessary
> > to (1) activate libvorbis in allcodecs.c, and (2) use a different codec ID
> > for vorbis and libvorbis (or change the lookup system). Am I right?
> 
> Ugh, that lookup system seems really bottom-up, you have to specify the
> name of an encoder (not a format name) which then is converted into a
> format specifier, which probably is used again to select an encoder.
> In addition, some presets or whatever use the same option parser to set
> the encoder with the name "ac3" instead of setting AC3 format...
> Talk about combining the disadvantages of all possible solutions...

well fix ffmpeg.c to use avcodec_find_encoder_by_name()

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070524/04641973/attachment.pgp>