[FFmpeg-devel] [PATCH] dts in avi fix

[Michael Niedermayer]

Hi

On Mon, May 21, 2007 at 05:35:30PM +0200, Benjamin Larsson wrote:
> Michael Niedermayer skrev:
> > Hi
> >
> > On Mon, May 21, 2007 at 07:06:18AM +0200, Benjamin Larsson wrote:
> >   
> >> Benjamin Larsson wrote:
> >>     
> >>> $topic
> >>>
> >>> Playing this file doesn't work to well.
> >>>
> >>> http://samples.mplayerhq.hu/A-codecs/DTS/dtsac3audiosample.avi
> >>>
> >>> With parsing it works abit better but the decoder still complains.
> >>>
> >>> MvH
> >>> Benjamin Larsson
> >>>
> >>>       
> >> I'll apply this in a few days. If noone speaks up.
> >>     
> >
> > this patch is wrong, parsing is already enabled, you changes just disables
> > the timestamp interpolation
> >
> > and feel free to rename AVSTREAM_PARSE_TIMESTAMPS to a more intuitive name
> >
> > [...]
> >
> >   
> 
> 
> Well without the patch the decoder is called with frames larger then the 
> allowed max frame size. I just assumed that dts in avi is just as hacked 
> up as mp3 in avi. (Fragmented frames.) And that the way to fix it is to 
> let the parser collect complete frames. So what am I missing ?

case CODEC_TYPE_AUDIO:
[...]
/* Force parsing as several audio frames can be in
 * one packet and timestamps refer to packet start*/
st->need_parsing = AVSTREAM_PARSE_TIMESTAMPS;

and

 AVSTREAM_PARSE_TIMESTAMPS, /**< full parsing and [...] */

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070521/d1aa3146/attachment.pgp>