[FFmpeg-devel] [PATCH] Add rtsp options support ( added option)

[Michael Niedermayer]

Hi

On Mon, May 21, 2007 at 10:09:43AM +0200, Thijs Vermeir wrote:
> Hi
> 
> On Thu, 2007-05-17 at 15:37 +0200, Michael Niedermayer wrote:
> Hi
> >
> >On Wed, May 16, 2007 at 10:13:10AM +0200, Thijs Vermeir wrote:
> >> Hi
> >>
> >> On Tue, 2007-05-15 at 23:25 +0200, Michael Niedermayer wrote:
> >> >Hi
> >> >
> >> >On Tue, May 15, 2007 at 06:01:02PM +0200, Thijs Vermeir wrote:
> >> >> Hello all,
> >> >>
> >> >> This patch allows the use rtsp options. This patch does not add
> >> >> options but just create the possibility to add options like in the udp
> >> >> protocol (ip:port?options)
> >> >> Possible options (to be implemented in the future) are:
> >> >
> >> >summary this patch adds no feature but it makes the code more complex
> >> >after someone submits patches which add options this could be 
> >reconsidered
> >>
> >> Ok,
> >> I added the first options for rtsp. Now, you can select via an option
> >> which transport method needs to be used. ('udp','multicast' or 'tcp').
> >
> >this patch contains a previous patch by you (the option patch)
> >-> rejected, split it into incremental patches
> 
> Ok, I splitted the patches up in two incremental patches.
> (1/2) -> Add support for options
> (2/2) -> Add transport method options

[...]
> +    /* search for options */
> +    option_list = strchr(path, '?');
> +    if (option_list)
> +    {
> +        /* remove the options from the path */

the {} placement is inconsistent with the rest of the file


> +        path[option_list++ - path] = 0;

obfuscated ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070521/dd984e67/attachment.pgp>