[FFmpeg-devel] [PATCH] List enabled parts in configure output

[Ramiro Ribeiro Polla]

Hello,

Alex Beregszaszi wrote:
> Hi,
>
> Attached is an updated version of the patch. It has been
> corrected/rewritten by Ivo van Poorten and Aurelien Jacobs. This version
> contains bitstreamfilter support and applies cleanly.
>
> If noone is against it, I will apply it tomorrow.
>
>   

I still think it's too much information to always print out 
unconditionally (=slower configure and larger output).

> Index: configure
> ===================================================================
> --- configure	(revision 9047)
> +++ configure	(working copy)
> @@ -2039,17 +2039,24 @@
>  fi
>  
>  
> -for part in $DECODER_LIST $ENCODER_LIST $PARSER_LIST $BSF_LIST $DEMUXER_LIST $MUXER_LIST $PROTOCOL_LIST; do
> +for type in decoder encoder parser bsf demuxer muxer protocol; do
> +    echo -n "Enabled ${type}s:"
> +    list="$`toupper $type`_LIST"
> +    enabled_list=""
> +    for part in `eval echo $list`; do
>      ucname="`toupper $part`"
>      config_name="CONFIG_$ucname"
>      enabled_name="ENABLE_$ucname"
>      if enabled $part; then
> +        enabled_list="$enabled_list $part"
>          echo "#define $config_name 1" >> $TMPH
>          echo "#define $enabled_name 1" >> $TMPH
>          echo "$config_name=yes" >> config.mak
>      else
>          echo "#define $enabled_name 0" >> $TMPH
>      fi
> +    done
> +    echo -e "$enabled_list\n" | sed -e "s/_$type//g"
>  done
>   

It's better to move "echo -n "Enabled ${type}s:" right before echoing 
the enabled_list. There's a big lag to make the list in MSys (on Linux 
it's smaller, but it's still there).

The information is too close together. I'd personally prefer for the 
layout to be like "ffmpeg -formats".
Also, the "\n"s look weird. Either no line breaks, or break between 
"Creating config.mak and config.h..." and the first line looks better.

Ramiro Polla