[FFmpeg-devel] [PATCH] Make vp3dsp*.c compilation optional

[Jason Millard]

>
> Patch mostly ok. See my remark.
>
> >  OBJS-$(CONFIG_GPL)                     += i386/idct_mmx.o
> >  OBJS-$(CONFIG_CAVS_DECODER)            += i386/cavsdsp_mmx.o
> >  OBJS-$(CONFIG_SNOW_DECODER)            += i386/snowdsp_mmx.o
> > +OBJS-$(CONFIG_VP3_DECODER)             += i386/vp3dsp_mmx.o i386/vp3dsp_sse2.o
> > +OBJS-$(CONFIG_VP5_DECODER)             += i386/vp3dsp_mmx.o i386/vp3dsp_sse2.o
> > +OBJS-$(CONFIG_VP6_DECODER)             += i386/vp3dsp_mmx.o i386/vp3dsp_sse2.o
> > +OBJS-$(CONFIG_THEORA_DECODER)          += i386/vp3dsp_mmx.o i386/vp3dsp_sse2.o
> >  endif
>

Are these patches set to go in soon? SVN isn't compiling using the
following config:

 ./configure --disable-demuxers --disable-decoders --disable-muxers
--disable-encoders --disable-parsers --disable-protocols
--enable-demuxer=asf --enable-decoder=wmav2 --enable-protocol=tcp
--enable-protocol=http --enable-encoder=mp3lame --enable-memalign-hack
--disable-debug --enable-libmp3lame --enable-gpl --disable-ffserver
--disable-ffplay --enable-small --extra-cflags=-I/usr/local/include
--extra-ldflags=-L/usr/local/lib

errors:

gcc -L"/c/ffmpeg-05-16-07"/libavformat
-L"/c/ffmpeg-05-16-07"/libavcodec -L"/c/ffmpeg-05-16-07"/libavutil
-Wl,--warn-common  -L/usr/local/lib
-Wl,-rpath-link,"/c/ffmpeg-05-16-07"/libavcodec
-Wl,-rpath-link,"/c/ffmpeg-05-16-07"/libavformat
-Wl,-rpath-link,"/c/ffmpeg-05-16-07"/libavutil -g -o ffmpeg_g.exe
ffmpeg.o cmdutils.o -lavformat -lavcodec -lavutil -lws2_32 -lm
-lmp3lame -lm
c:/ffmpeg-05-16-07/libavcodec/libavcodec.a(dsputil_mmx.o):dsputil_mmx.c:(.text+0x164b5):
undefined reference to `ff_vp3_idct_sse2'
c:/ffmpeg-05-16-07/libavcodec/libavcodec.a(dsputil_mmx.o):dsputil_mmx.c:(.text+0x164df):
undefined reference to `ff_vp3_idct_sse2'
c:/ffmpeg-05-16-07/libavcodec/libavcodec.a(dsputil_mmx.o):dsputil_mmx.c:(.text+0x16509):
undefined reference to `ff_vp3_idct_mmx'
c:/ffmpeg-05-16-07/libavcodec/libavcodec.a(dsputil_mmx.o):dsputil_mmx.c:(.text+0x16533):
undefined reference to `ff_vp3_idct_mmx'
collect2: ld returned 1 exit status
make: *** [ffmpeg_g.exe] Error 1

-- Jason