[FFmpeg-devel] [PATCH] remove __attribute__((unused))

[Måns Rullgård]

Reimar D?ffinger wrote:
> Hello,
> On Sun, May 13, 2007 at 09:49:59PM +0200, Michael Niedermayer wrote:
>> On Sun, May 13, 2007 at 06:51:01PM +0200, Reimar D?ffinger wrote:
>> [...]
>> > > > Index: libavcodec/h264.c
>> > > > ===================================================================
>> > > > --- libavcodec/h264.c	(revision 9014)
>> > > > +++ libavcodec/h264.c	(working copy)
>> > > > @@ -1800,7 +1800,7 @@
>> > > >      const int lt= src[-1-1*stride];
>> > > >      LOAD_TOP_EDGE
>> > > >      LOAD_LEFT_EDGE
>> > > > -    const __attribute__((unused)) int unu= l3;
>> > > > +    const int unu= l3;
>> > >
>> > > This and similar cases is to kill a warning about l3 (or whatever)
>> > > being unused.  The variable l3 is declared by the macro
>> > > LOAD_LEFT_EDGE, but isn't used everywhere this macro is invoked.  I
>> > > think the proper solution is to put attribute_unused on all the
>> > > variables declared by those macros.
>> >
>> > I tend to agree but this is for the maintainers to decide.
>>
>> iam ok with it ...
>
> Like in attached patch?

That's how I meant, but please put the attribute_unused to the left of the
variable name.  Either side works, but I think it looks strange having it
on the right.

-- 
M?ns Rullg?rd
mans at mansr.com