[FFmpeg-devel] [PATCH] Make h264idct.c compilation optional

Panagiotis Issaris takis.issaris
Mon May 14 13:58:11 CEST 2007

Hash: SHA1


The attached patch tries to make the h264idct.c compilation optional.
Not meant for direct inclusion, as I am not sure about the correctness...

In dsputil_init() currently [1], for lowres decoding, when idct_algo's
other than FF_IDCT_INT or FF_IDCT_AUTO are selected, h264 related
functions (ff_h264_lowres_idct_put|add_c) are being used. Are these two
functions in fact more generic then their name implies (in fact just
misnamed), and should they be relocated to some other common file?

Or are they really H.264 specific functions? ... but in that case it
seems weird that selecting f.e. FF_IDCT_VP3 or FF_IDCT_SIMPLEMMX would
result in using these H.264 specific functions.

 Makefile  |    3 +--
 dsputil.c |   12 +++++++-----
 2 files changed, 8 insertions(+), 7 deletions(-)

I've also added git-format-patch generated files, for the git users
using git-am :) The git-format-generated patches separate the
indentation from the functional changes.

With friendly regards,

3860     if(avctx->lowres==1){
3861         if(avctx->idct_algo==FF_IDCT_INT ||
3862             c->idct_put= ff_jref_idct4_put;
3863             c->idct_add= ff_jref_idct4_add;
3864         }else{
3865             c->idct_put= ff_h264_lowres_idct_put_c;
3866             c->idct_add= ff_h264_lowres_idct_add_c;
3867         }
3868         c->idct    = j_rev_dct4;
3869         c->idct_permutation_type= FF_NO_IDCT_PERM;
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20070514T133922-ffmpeg-optional_h264idct_compilation.diff
Type: text/x-patch
Size: 1967 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070514/b72feec8/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Make-h264idct.o-compilation-optional.patch
Type: text/x-patch
Size: 2116 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070514/b72feec8/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Reindent.patch
Type: text/x-patch
Size: 990 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070514/b72feec8/attachment-0002.bin>

More information about the ffmpeg-devel mailing list