[FFmpeg-devel] [PATCH] remove __attribute__((unused))

matthieu castet castet.matthieu
Sun May 13 14:56:28 CEST 2007


Hi Reimar,

Reimar Doeffinger wrote:
> Hello,
> attached patch would just remove them, since I don't really know what
> their point is (probably just removing warnings?).
> Probably a better fix would be to define attribute_unused just as it was
> done for attribute_used.
> Please say what you think.
 > -static const __attribute((used)) uint8_t 
last_coeff_flag_offset_8x8[63] = {
 > +static const uint8_t last_coeff_flag_offset_8x8[63] = {

You are not doing what's the patch was supposed to to : you remove some 
*used* attribute.


IIRC this breask asm, as gcc thinks that these symbols are useless and 
remove them.


Matthieu




More information about the ffmpeg-devel mailing list