[FFmpeg-devel] [PATCH] add ENOENT support

Michael Niedermayer michaelni
Sat May 12 17:12:15 CEST 2007


Hi

On Sat, May 12, 2007 at 02:34:02PM +0200, Fran?ois Revol wrote:
> > Michael Niedermayer wrote:
> > > Hi
> > >
> > > On Thu, May 10, 2007 at 12:17:34PM +0200, Benoit Fouet wrote:
> > >   
> > >> Hi,
> > >>
> > >> this patch uses url_fopen error code and creates a define
> > >> for AVERROR_NOENT
> > >>     
> > >
> > > patch ok
> > >
> > >
> > >   
> > >> i don't know whether it has to be splitted or not
> > >>     
> > >
> > > addition of AVERROR_NOENT could be split off if you like, yes ...
> > >
> > applied both separately
> 
> Rejected.
> 
> AVERROR_* are *deprecated*.
> They are only kept for compatibility with apps.
> There is no reason to not use POSIX error codes directly with the 
> AV[UN]ERROR() macros, that's what they are for. The libraries already 
> returns more errors than the listed ones.
> If you want to print an error just use strerror(AVUNERROR(e)).

all true, but why are there still AVERROR_* in the source then (not counting
the compatibility stuff in the header of course)?

having AVERROR_* in some code and POSIX errors in other is not good it leads
to people writing such patches with noone realizing that its wrong ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070512/b2d93d9f/attachment.pgp>



More information about the ffmpeg-devel mailing list