[FFmpeg-devel] PATCH BlackFin yuv2rgb color space conversion

[Michael Niedermayer]

Hi

On Tue, May 08, 2007 at 08:46:32PM -0400, Marc Hoffman wrote:
> 
> Blackfin optimized YUV420 to RGB CSC Color Space Converters.
> 
> This patch includes YUV2 -> RGB BGR for 565, 555 and 888 a.k.a. 24bit  
> color.
> 
> Performance gain compared against -O3:
> 
> 2779809/1484290 187.28%
> 
> which normalized translates to ~33c/pel for the reference C vs ~17.5
> c/pel for this optimized implementation.
> 
> Please review again, I hope I got everyones points if I didn't I'm  
> sorry but there was a lot of feedback in the first round.

the mime type was application/octect stream which isnt correct for a patch

[...]
> +    if (masks == 555) {
> +        c->rmask = 0x001f * 0x00010001U;
> +        c->gmask = 0x03e0 * 0x00010001U;
> +        c->bmask = 0x7800 * 0x00010001U;
> +    } else if (masks == 565) {
> +        c->rmask = 0x001f * 0x00010001U;
> +        c->gmask = 0x07e0 * 0x00010001U;
> +        c->bmask = 0xf800 * 0x00010001U;
> +    }

the r/bmask can be factored out of the if/else


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070509/d6e6c79a/attachment.pgp>