[FFmpeg-devel] [PATCH] TXD demuxer and decoder

[Michael Niedermayer]

Hi

On Mon, May 07, 2007 at 07:24:54PM +0200, Ivo wrote:
> Hi,
> 
> On Monday 07 May 2007 16:34, Michael Niedermayer wrote:
> > On Mon, May 07, 2007 at 03:35:57PM +0200, Ivo wrote:
> > > BTW shouldn't I replace le2me_{16,32} by AV_RL{16,32} too?
> >
> > if they are guaranteed to be aligned (i think so IIRC) then the le2me()
> > can stay, it might be faster (or maybe not but i guess benchmarking this
> > on several arhcitectures (on x86 they should be the same) isnt worth it
> > ...)
> 
> Yes. They read from 2 and 4 byte boundaries relative to the start of src, so 
> it depends on how the functions are called. Currently, all calling code 
> (=txd decoder only) pass on pointers that are properly aligned, so it works 
> correctly. If the s3tc functions are ever reused, the caller must assure 
> that src is properly aligned and if that's not possible, this code has to 
> be changed.

id say document the alignment requirements in a doxygen comment in the header

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I count him braver who overcomes his desires than him who conquers his
enemies for the hardest victory is over self. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070507/abb9d727/attachment.pgp>