[FFmpeg-devel] [PATCH] add dca and vc1 objects to Makefile when parsers are enabled

[Michael Niedermayer]

Hi

On Thu, May 03, 2007 at 06:06:17PM +0200, Diego Biurrun wrote:
> On Thu, May 03, 2007 at 12:07:56PM +0200, Michael Niedermayer wrote:
> > 
> > On Thu, May 03, 2007 at 11:54:56AM +0200, Diego Biurrun wrote:
> > > On Thu, May 03, 2007 at 09:28:57AM +0200, Benoit Fouet wrote:
> > > > 
> > > > seen on ffmpeg user mailing list
> > > > when disabling en/decoders, those two objects are not built even though
> > > > they are needed to parse
> > > 
> > > The patch is OK, but I think it would be better to put the dca and vc1
> > > parser code in parser.c along with the rest of the parsers.  The parser
> > > code is a very small part of both decoders.
> > 
> > _all_ parsers should be put in seperate files. putting them in parser.c
> > is an extreemly ugly hack and while i agreed for ac3 as noone was willing
> > to solve that properly i will NOT agree to move the other parsers to the
> > wrong file too!
> 
> So let's start.  Here is a patch that moves the dca parser to its own file.
> 
> I have named it dca_parser.c.  That looks like a sane naming scheme to
> me.  I have created dca.h and dca_parser.c with svn cp in my local tree
> but I have diffed them against /dev/null to send here, multithousand
> line patches are not particularly easy to read.

well, if they are 95% line removial then they are easy to read, just clip
the lines with - away and review the remainder which could very well be 
smaller than a diff against the bit bucket

and patch looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070503/00e60965/attachment.pgp>