[Ffmpeg-devel] Re: Bethsoft VID demuxer and decoder

[Michael Niedermayer]

Hi

On Tue, Mar 27, 2007 at 05:32:51PM -0400, Rich Felker wrote:
> On Tue, Mar 27, 2007 at 11:13:37PM +0200, Michael Niedermayer wrote:
> > [...]
> > > +    static int is_finished;                         // if terminating block is reached, don't need to read junk afterwards
> > 
> > non constant static variables break thread safety
> 
> Usually it's not just a matter of threads but of multiple decoder
> instances in general.

true


> 
> > [...]
> > > +        case FIRST_AUDIO_BLOCK: av_log(s, AV_LOG_VERBOSE, "first audio block.\n"); exit(0);
> > > +        case AUDIO_BLOCK: av_log(s, AV_LOG_VERBOSE, "audio block.\n"); exit(0);
> > 
> > calling exit() in a demuxer is not ok
> 
> Maybe handle exit like printf, etc.? :)

done


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I count him braver who overcomes his desires than him who conquers his
enemies for the hardest victory is over self. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070327/8d164f16/attachment.pgp>