[Ffmpeg-devel] [PATCH] h264 - loopify some get_cabac calls

[Guillaume POIRIER]

Hi,

On 3/26/07, Loren Merritt <lorenm at u.washington.edu> wrote:
> On Sun, 25 Mar 2007, Guillaume POIRIER wrote:
> > On 3/25/07, Alexander Strange <astrange at ithinksw.com> wrote:
> >
> >> I think the stuff in transpose6x16 can be cleaned up; it should be
> >> able to use vec_ste instead of copying the result array.
> >>
> >> But this is my first time studying it too; I didn't write it.
> >
> > Ok. Who may that be? I attached a patch that uses these altivec
> > routines on x264. I looks like they don't produce bit-identical
> > results as the C version, but maybe it's just because I haven't
> > modifed what needed to to make them work on x264 environment.
>
> Cosmetics:
> Based on their function, I would expect the transposes to be called
> transpose16x6 and transpose4x16.
>
> What kind of filename is altivec_lum.c? All the files in that directory
> are altivec, and most of them use luma.

Ahem. The filename indeed sucks. I should be deblock.c. I forgot to
mention that I just pretty much edited the original patch
(altivec_lum.3.diff) and modified what needed to be fixed to make it
compile with x264's own defines.
So the names of function should all eventually be changed to meet
x264's naming conventions.

But before that, this patch needs to be fixed so that it computes the
same result as C version.

I hope to find the time to look at it eventually.

Guillaume