[Ffmpeg-devel] Building failure on Darwin from SVN HEAD

[millenomi]

Hi list,
I was building ffmpeg for my own nefarious purposes (bwhahahah) and I
got the following error from MacPorts:

...
cc -DHAVE_AV_CONFIG_H -I..
-I/opt/local/var/db/dports/build/_opt_local_var_db_dports_sources_rsync.rsync.darwinports.org_dpupdate_dports_multimedia_ffmpeg/work/trunk/libavutil
-I/opt/local/include -DHAVE_LRINTF -no-cpp-precomp -pipe
-force_cpusubtype_ALL -Wno-sign-compare -fomit-frame-pointer -g
-Wdeclaration-after-statement -Wall -Wno-switch
-Wdisabled-optimization -Wpointer-arith -Wredundant-decls -Winline -O3
-mdynamic-no-pic -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
-D_ISOC9X_SOURCE    -c -o x264.o x264.c
x264.c: In function 'X264_init':
x264.c:147: error: 'struct <anonymous>' has no member named 'i_rf_constant'

In fact I looked at x264.c, and then in the included x264.h built by
MacPorts from x264 SVN HEAD. In fact it does not have a i_rf_constant
member, but it does have a f_rf_constant member (float rather than
int). I have fixed (absolutely not knowing what I was doing -- is it
wrong?) x264.c:147 by replacing i_rf_constant with f_rf_constant and
adding a cast to (float). It builds fine after that.

Is it right? I haven't tested the built product yet.

-- 
 - ?