[Ffmpeg-devel] [PATCH] Fix compilation when using --disable-opts

[Panagiotis Issaris]

Hi,

M?ns Rullg?rd schreef:
> Aurelien Jacobs <aurel at gnuage.org> writes:
>> On Thu, 15 Mar 2007 18:26:47 +0100
>> Panagiotis Issaris <takis.issaris at uhasselt.be> wrote:
>>> M?ns Rullg?rd schreef:
>>>> Diego Biurrun said:
>>>>> On Thu, Mar 15, 2007 at 05:58:35PM +0100, Panagiotis Issaris wrote:
>>>>>> The attached patch fixes compilation when using the --disable-opts
>>>>>> parameter. This to help those interested in using a debugger to debug
>>>>>> FFmpeg.
>>>>> Looks good.
>>>> No, the configure changes lack indentation.
>>> Like this?
>>>
>>> [...]
>>>
>>> @@ -1390,6 +1392,31 @@ if test "$?" != 0; then
>>>      die "C compiler test failed."
>>>  fi
>>>  
>>> +if test $arch = "x86_32"; then
>>> +    # check whether EBP is available on x86
>>> +    # As 'i' is stored on the stack, this program will crash
>>> +    # if the base pointer is used to access it because the
>>> +    # base pointer is cleared in the inline assembly code.
>>> +    ebp_available=no
>> Shouldn't this be replaced with "disable ebp_available" ? (same for ebx)
> 
> In fact, it can be removed entirely.  Unset is mostly equivalent to
> "no".
Updated patch attached.

 configure           |   25 +++++++++++++++++++++++++
 libavcodec/cabac.h  |    4 ++--
 libavcodec/h264.c   |    2 +-
 libavutil/x86_cpu.h |    4 ++++
 4 files changed, 32 insertions(+), 3 deletions(-)

With friendly regards,
Takis
-- 
vCard: http://www.issaris.org/pi.vcf
Public key: http://www.issaris.org/pi.key
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20070316T004826-ffmpeg-disable_opts3.diff
Type: text/x-patch
Size: 3227 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070316/7452725a/attachment.bin>