[Ffmpeg-devel] Re: [PATCH] Fix compilation when using --disable-opts

[Ramiro Polla]

Hello,

M?ns Rullg?rd escreveu:
> Panagiotis Issaris said:
>   
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Hi,
>>
>> M?ns Rullg?rd schreef:
>>     
>>> Diego Biurrun said:
>>>       
>>>> On Thu, Mar 15, 2007 at 05:58:35PM +0100, Panagiotis Issaris wrote:
>>>>         
>>>>> The attached patch fixes compilation when using the --disable-opts
>>>>> parameter. This to help those interested in using a debugger to debug
>>>>> FFmpeg.
>>>>>           
>>>> Looks good.
>>>>         
>>> No, the configure changes lack indentation.
>>>       
>> Like this?
>>     
>
> Yes.  A couple of things though: won't this leave a core dump behind if the ebp
> test fails?
This is the same doubt I had for the configure part in [1]. On Windows 
XP, crashes issue a dialog box (and so configure has to wait). Of course 
you won't decide if it's ok to crash a program on configure just because 
of Windows users, but it would be nice to just put a warning before 
running the tests: "This configure script might crash and generate a 
core dump" (or something similar).

Ramiro Polla

[1] http://article.gmane.org/gmane.comp.video.ffmpeg.devel/46283