[Ffmpeg-devel] [PATCH] Fix --disable-opts compilation

[Michael Niedermayer]

Hi

On Thu, Mar 15, 2007 at 02:50:03PM +0100, Panagiotis Issaris wrote:
[...]
> > [...]
> >> diff --git a/libavcodec/cabac.h b/libavcodec/cabac.h
> >> index fc9fc6d..e8b1b88 100644
> >> --- a/libavcodec/cabac.h
> >> +++ b/libavcodec/cabac.h
> >> @@ -376,7 +376,7 @@ static int av_always_inline get_cabac_inline(CABACContext *c, uint8_t * const st
> >>  #define BYTE        "16"
> >>  #define BYTEEND     "20"
> >>  #endif
> >> -#if defined(ARCH_X86) && !(defined(PIC) && defined(__GNUC__))
> >> +#if defined(ARCH_X86) && defined(CONFIG_EBP) && defined(CONFIG_EBX)
> >>      int bit;
> > 
> > this is wrong it explicitly refers to EBX but not top EBP it just uses 7
> > registers which with x86-32 means ebp must be used
> > correct would be
> I'm having difficulties parsing the above :) But, I think you are trying
> to say that the real problem is that seven registers are needed in that
> specific piece on inline assembly. Which are not available on x86_32 if
> a basepointer is used. Right?

almost, in addition to this the specific asm code currently explicitly
usees ebx, even on x86-64


[...]

> Shouldn't this entire architecture
> specific code be moved into i386/?

yes

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070315/9b95a085/attachment.pgp>