[Ffmpeg-devel] [PATCH] Move libavformat Doxygen and other comments to avformat.h

[Michael Niedermayer]

Hi

On Fri, Mar 09, 2007 at 12:35:55AM +0100, Panagiotis Issaris wrote:
> Hi
> 
> Michael Niedermayer schreef:
> > On Sat, Mar 03, 2007 at 10:48:07PM +0100, Panagiotis Issaris wrote:
> >> Panagiotis Issaris schreef:
> >>> Panagiotis Issaris schreef:
> >>>> Michael Niedermayer schreef:
> >>>>> On Thu, Mar 01, 2007 at 05:12:46PM +0100, Panagiotis Issaris wrote:
> >>>>> [...]
> >>>>>
> >>>>>> +/**
> >>>>>> + * Print  nice hexa dump of a buffer
> >>>>>> + * @param f stream for output
> >>>>>> + * @param buf buffer
> >>>>>> + * @param size buffer size
> >>>>>> + */
> >>>>>> void av_hex_dump(FILE *f, uint8_t *buf, int size);
> >>>>>> +
> >>>>>> +/**
> >>>>>> + * Print on 'f' a nice dump of a packet
> >>>>>> + * @param f stream for output
> >>>>>> + * @param pkt packet to dump
> >>>>>> + * @param dump_payload true if the payload must be displayed too
> >>>>>> + */
> >>>>>> void av_pkt_dump(FILE *f, AVPacket *pkt, int dump_payload);
> >>>>>>    
> >>>>> these should be changed to av_logish style, (FILE dependancy sucks ...)
> >>>>> thats of course seperate and independant of this patch
> >>>>>  
> >>>> OK, I'll write a patch for this later today.
> >>> Oh, and furthermore, should I give the new av_(pkt|hex)_dump new 
> >>> names? 
> > 
> > yes, and you will need a hex_dump_internal() which can handle both
> > FILE and av_log ...
> > 
> > that is unless you or someone else has a better idea ...
> > 
> > 
> >>> Or how should the API change be handled?
> >>>
> >>>
> >>> av_hex_dump_log & av_pkt_dump_log
> > 
> > looks best but i have no strong preference ...
> > [...]
> The attached patch introduces two new logging functions
> av_hex_dump_log() and av_pkt_dump_log() which use av_log() for logging
> instead of fprintf().
> 
>  ffmpeg.c               |    2 -
>  ffserver.c             |    2 -
>  libavformat/avformat.h |   38 ++++++++++++++++++++++++++----
>  libavformat/mpegts.c   |   10 +++----
>  libavformat/utils.c    |   62
> +++++++++++++++++++++++++++++++++----------------
>  5 files changed, 84 insertions(+), 30 deletions(-)

looks ok


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070310/e46fd657/attachment.pgp>