[Ffmpeg-devel] [PATCH] remove the_end label

[Benoit Fouet]

Hi,

Limin Wang wrote:
> Hi,
>
> As the result of last removing the unused variable patch. Please review it.
>
>
> Thanks,
> Limin
>   
> ------------------------------------------------------------------------
>
> Index: ffmpeg.c
> ===================================================================
> --- ffmpeg.c	(revision 8284)
> +++ ffmpeg.c	(working copy)
> @@ -714,7 +714,7 @@
>      if (ost->video_crop) {
>          if (av_picture_crop((AVPicture *)&picture_crop_temp, (AVPicture *)in_picture, dec->pix_fmt, ost->topBand, ost->leftBand) < 0) {
>              av_log(NULL, AV_LOG_ERROR, "error cropping picture\n");
> -            goto the_end;
> +            return;
>          }
>          formatted_picture = &picture_crop_temp;
>      } else {
> @@ -729,7 +729,7 @@
>          if (ost->video_resample) {
>              if (av_picture_crop((AVPicture *)&picture_pad_temp, (AVPicture *)final_picture, enc->pix_fmt, ost->padtop, ost->padleft) < 0) {
>                  av_log(NULL, AV_LOG_ERROR, "error padding picture\n");
> -                goto the_end;
> +                return;
>              }
>              resampling_dst = &picture_pad_temp;
>          }
> @@ -828,8 +828,6 @@
>          ost->sync_opts++;
>          ost->frame_number++;
>      }
> - the_end:
> -    return;
>  }
>  
>  static double psnr(double d){
>   
>   
or, as Michel suggested:

@@ -828,8 +828,6 @@
         ost->sync_opts++;
         ost->frame_number++;
     }
- the_end:
+ the_end:;

Ben