[Ffmpeg-devel] [PATCH] fix -ab default

[Michael Niedermayer]

Hi

On Tue, Mar 06, 2007 at 10:27:05PM +0100, Michael Niedermayer wrote:
[...]
> > >  
> > > -    av_opt_set_defaults(s);
> > > +    if(codec_type == CODEC_TYPE_AUDIO)
> > > +        flags= AV_OPT_FLAG_AUDIO_PARAM;
> > > +    else if(codec_type == CODEC_TYPE_VIDEO)
> > > +        flags= AV_OPT_FLAG_VIDEO_PARAM;
> > > +    av_opt_set_defaults2(s, flags);
> > >   
> > no AV_OPT_FLAG_SUBTITLE_PARAM handling ?
> 
> fixed
> 
> ive also fixed the missing prototype in avcodec.h
> 
> new patch attached
> 
> with it
> -ab X -b Y also works like before with the exception that -ab is in bits/sec
> 
> so are there any comments about the API changes? as they where what i
> actually would like feedback on, adding a AV_OPT_FLAG_SUBTITLE_PARAM
> later is trivial changing API is always problematic ...

patch applied with a note about that avcodec_get_context_defaults2() and
avcodec_alloc_context2() are not yet part of the public API
and opt.c part with a flags+mask instead of just flags

patch application has been in 6 incremental changes with regression tests
passing between them

ill leave a possible CodecType->CodecID change to whoever wants to work
on it

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070307/984ed47f/attachment.pgp>