[Ffmpeg-devel] [PATCH] Update docs according to new "ab" parameter unit

[Michael Niedermayer]

Hi

On Tue, Mar 06, 2007 at 03:55:58PM +0100, Baptiste Coudurier wrote:
> Benoit Fouet wrote:
> > Hi,
> > 
> > Michael Niedermayer wrote:
> >> Hi
> >>
> >> On Tue, Mar 06, 2007 at 03:05:57PM +0100, Benoit Fouet wrote:
> > [snip]
> >>> the only options i see for the moment that works like that are "ab" and
> >>> "vb" (and potentially "sb")
> >>>     
> >> -adebug -vdebug -debug should work too
> >>
> >> and potentially things like -qscale, -bt, -flags bitexact, -strict
> >> -er -ec -coder -context -minrate -maxrate, -pred, -psnr, ...
> >>
> >> would work if a audio codec used them ...
> >>
> >> [...]
> >>   
> >>   
> > true
> > (maybe needing a little rework of opt default as only avctx_opts[0] is
> > checked for debug and bitexactness at the moment...)
> > 
> > well... why don't we just revert the patch ?

well we need a solution, revert is not a solution, that said ive
no objections to reverting it but IMHO we should first decide what we do
want before blindly reverting because it not clear at all if the change
is bad and a completely different design is wanted or merely buggy

so please ...
if the change is really causing problems for you revert it if not
either help finding a solution OR leave thouse who try to find one
alone and dont flame with silly revert! calls


so what is wanted?
-ab/-vb defaults like before? this is unrelated to the change, revert will
not help it will just hide the bug
avcodec_get_context_defaults() is what sets the default and that has no
knowledge about the codec_type
we could add a avcodec_get_context_defaults2() with takes a codec_id
as parameter and sets defaults based on that


> > now that some people are involved, we could have some more reactions, no ?
> > 
> 
> maybe, I don't mind, except for the 200k default audio bitrate which is
> too much IMHO, and yes Im faulty for not having spoken in the thread,
> because I did not realize that this change involved changing it, when we
> changed "-b" behaviour, default bitrate did not change.
> 
> Michael, can we state in ffmpeg policy that API changes should be deeply
> discussed, and something like "last call, speak now or stay quiet"
> should be sent before applying ?

this change was sent as patch, the patch was resent several times, and
it was disscussed, if people dont read it thats their problem IMHO

additionally the patch doesnt change the API but the commandline
handling of ffmpeg.c

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070306/0ac0731e/attachment.pgp>