[Ffmpeg-devel] [PATCH] accept only existing bitrates in amr.c

[Benoit Fouet]

Hi,

M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
>
>   
>> i prefer using the return value for both enum and -1 error yes, enum==int
>> anyway
>> or if you recently have been brainwashed by some CS teachers then just add
>> a enum entry for error and give it the value -1
>>     
>
> An enum isn't required to be int.  The compiler may choose any integer
> type capable of representing the full range of the enum values.  The
> enumeration constants have type int, but that's another matter.
>
>   

well, the enumerated has a unsigned type in our case...
so, i can either have two different behaviours for NB and WB, or change
"enum Mode mode" to "int mode" in AMR context...
i don't know what is better to do...

Ben