[Ffmpeg-devel] [RFC] D10 IMX patch encoding

[Baptiste Coudurier]

Michael Niedermayer wrote:
> Hi
> 
> On Sat, Mar 03, 2007 at 08:44:36PM +0100, Baptiste Coudurier wrote:
> [...]
>>>> +    *poutbuf = av_malloc(buf_size + 20 + FF_INPUT_BUFFER_PADDING_SIZE);
>>>> +    poutbufp = *poutbuf;
>>>> +    memcpy(poutbufp, imx_header, 16);
>>>> +    poutbufp += 16;
>>>> +    *poutbufp++ = 0x83; /* KLV BER long form */
>>>> +    AV_WB24(poutbufp, buf_size);
>>>> +    poutbufp += 3;
>>>> +    memcpy(poutbufp, buf, buf_size);
>>>> +    poutbufp += buf_size;
>>>> +    *poutbuf_size = poutbufp - *poutbuf;
>>> these could be done cleaner with the bytestream stuff but iam fine
>>> with the above too ...
>>>
>> Hummmmmmm, last time:
>> "id prefer if you use the bitstream stuff for the 3 lines"
>>
>> I was using bytestream stuff, sometimes I feel like a stupid sheep.
> 
> well indeed, i review alot of patches and dont remember every detail

I understand, thanks a lot.

> use of bytestream as you did originally is fine, better as i said
> originally is to use bitstream (get_bits/put_bits) as it would avoid
> inclusion of bytestream.h and would avoid addition of AV_WB24() / equivalent
> in bytestreamh use of AV_WB* ptr++ is least readable and i didnt suggest that

Ok, applied bytestream version.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312