[Ffmpeg-devel] Stack overflow patch

Michael Niedermayer michaelni
Fri Mar 2 11:58:16 CET 2007


Hi

On Thu, Mar 01, 2007 at 06:53:58PM -0800, Kristian Amlie wrote:
> Quoting Michael Niedermayer <michaelni at gmx.at>:
> 
> >On Thu, Mar 01, 2007 at 02:29:48PM -0800, Kristian Amlie wrote:
> >
> >>This patch fixes ffmpeg so that av_find_stream_info() can be called
> >>from MSVC++ without causing a stack overflow. It does so by replacing
> >>the auto array "duration_error" with a malloced array.
> >>
> >rejected, learn C what you write is a array of pointers, what it should be
> >is a pointer to array, difference is that its about 5 times less code
> 
> Right you are. My frequent C++/STL use has obviously dulled my senses.
> 
> This patch should be better.

yes looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070302/79dfd9d8/attachment.pgp>



More information about the ffmpeg-devel mailing list