[Ffmpeg-devel] Prefix for img_* functions
Panagiotis Issaris
takis.issaris
Thu Mar 1 17:41:53 CET 2007
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi,
Michael Niedermayer schreef:
> Hi
>
> On Thu, Mar 01, 2007 at 05:16:43PM +0100, Panagiotis Issaris wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Hi,
>>
>> Michael Niedermayer schreef:
>>> Hi
>>>
>>> On Mon, Feb 26, 2007 at 03:27:10AM +0100, Panagiotis Issaris wrote:
>>>> Hi,
>>>>
>>>> Shouldn't the img_crop, img_copy and img_pad functions get av_ prefixes?
>>> yes but the old should stay available under #if version something and
>>> with deprecated attribute
>> How would you prefer having the old versions available? Using #define's,
>> duplicate code or the old functions calling the new ones? Or some other way?
>
> #defines seem best after 5sec of thoughts
The attached patch adds the prefixes to img_crop, img_copy and img_pad.
ffmpeg.c | 8 ++++----
libavcodec/avcodec.h | 12 +++++++++---
libavcodec/imgconvert.c | 8 ++++----
libavcodec/imgresample.c | 2 +-
libavcodec/nuv.c | 2 +-
libavcodec/utils.c | 2 +-
6 files changed, 20 insertions(+), 14 deletions(-)
With friendly regards,
Takis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFF5wJR9kOxLuzz4CkRAhr8AJ4/Z+MBHOz2e0tcA1dAE1Nc4XdzXwCbBBPM
Q+AHQYthcYx9mbEdgDAsaIY=
=g/v/
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20070301T172954-ffmpeg-img_av_prefix.diff
Type: text/x-patch
Size: 6134 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070301/0badb7bf/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20070301T172954-ffmpeg-img_av_prefix.diff.sig
Type: application/octet-stream
Size: 65 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070301/0badb7bf/attachment.obj>
More information about the ffmpeg-devel
mailing list