[FFmpeg-devel] [patch] error codes for http/tcp

[Michael Niedermayer]

Hi

On Sat, Jun 30, 2007 at 02:07:48PM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On 6/30/07, Michael Niedermayer <michaelni at gmx.at> wrote:
> >
> > > Index: ffmpeg/libavformat/tcp.c
> > > ===================================================================
> > > --- ffmpeg.orig/libavformat/tcp.c     2007-06-05 02:11:13.000000000-0400
> > > +++ ffmpeg/libavformat/tcp.c  2007-06-23 10:38:41.000000000 -0400
> > > @@ -55,7 +55,7 @@
> > >
> > >      dest_addr.sin_family = AF_INET;
> > >      dest_addr.sin_port = htons(port);
> > > -    if (resolve_host(&dest_addr.sin_addr, hostname) < 0)
> > > +    if (resolve_host(&dest_addr.sin_addr, hostname, &ret) < 0)
> > >          goto fail;
> >
> > ret is overridden later so its confusing to use it here
> 
> 
> I said in my original email that my next patch (the tcp errno one) will
> actually use this function. Otherwise I have to merge the two patches in
> one, which would probably be confusing. Alternatively, I can add an extra
> variable already but leave it unused (i.e. not use it after filling in in
> resolve_host()) until the next patch. Whichever you prefer.

fine, forget this comment

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070630/87415118/attachment.pgp>