[FFmpeg-devel] [Patch] QT RLE encoder, bis

[Michael Niedermayer]

Hi

On Fri, Jun 29, 2007 at 08:01:22PM +0200, Alexis Ballier wrote:
[...]
> +/**
> + * Computes the best RLE sequence for a line
> + */
> +static void qtrle_encode_line(QtrleEncContext *s, AVFrame *p, int line, uint8_t **buf)
> +{
> +    int width=s->avctx->width;
> +    int i;
> +    signed char rlecode;
> +
> +    /* We will use it to compute the best bulk copy sequence */
> +    uint8_t bulkcount;
> +    /* This will be the number of pixels equal to the preivous frame one's
> +     * starting from the ith pixel */
> +    uint8_t skipcount;
> +    /* This will be the number of consecutive equal pixels in the current
> +     * frame, starting from the ith one also */
> +    uint8_t repeatcount;

these should be int or unsigend int not uint8_t, which might be very slow on
RISC architectures which lack 8bit registers/operations besides load/store

patch looks ok except this

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070629/40f7e3a7/attachment.pgp>