[FFmpeg-devel] [PATCH] split mpegvideo.c

[Michael Niedermayer]

Hi

On Thu, Jun 28, 2007 at 01:38:23PM +0200, Benoit Fouet wrote:
> Benoit Fouet wrote:
> > M?ns Rullg?rd wrote:
> >   
> >> Benoit Fouet <benoit.fouet at purplelabs.com> writes:
> >>   
> >>     
> >>> Hi,
> >>>
> >>> here is a first attempt to $subj
> >>>
> >>> what is done:
> >>>  - remove everything flagged under CONFIG_ENCODERS from mpegvideo.c
> >>> (apart from the DCT_common_init() part)
> >>>  - put those parts in mpegvideo_enc.c
> >>>     
> >>>       
> >> Does this in any way affect performance?  I can imagine calls from
> >> encoding functions to common functions no longer being inlined due to
> >> the split.  Then again, there might not be any relevant such calls.
> >>
> >>   
> >>     
> >
> > i didn't check performances yet. but this is a problem we might have, i
> > guess...
> >
> >   
> 
> anyway, what would be the proper way to do such a benchmark.
> As it is something i never did in ffmpeg, any pointer on how to do it
> would be very welcome !

nm anychangedobject.o

and checking if new function names appear (simply cleaning the output of nm
with sed and diffing them works well), if so they are no longer inlined
(this will tell us what needs benchmarking)

a time ffmpeg -i A B test for mpeg encoding and decoding
some START/STOP_TIMER tests for functions which we think might have changed
inlining behavior (see nm and what you changed in your patch)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070628/1534cce2/attachment.pgp>