[FFmpeg-devel] A question about AVOutputFormat.write_trailer (cosmetical)

[Aurelien Jacobs]

On Tue, 26 Jun 2007 22:48:21 +0200
Vitor <vitor1001 at gmail.com> wrote:

> Hi
> 
> Michael Niedermayer wrote:
> > On Tue, Jun 26, 2007 at 09:07:50PM +0200, Vitor wrote:
> >> Hi,
> >>
> >> For a good number of muxers (notably in raw.c), there is an empty 
> >> function that is passed to AVOutputFormat.write_trailer. The only place 
> >> it is called checks for a NULL pointer, and almost every muxer pass a 
> >> NULL pointer to AVOutputFormat.interleave_packet. So would it be ok to 
> >> send a patch to remove all those empty functions and set write_trailer 
> >> to NULL instead?
> > 
> > yes
> 
> Patch attached.
> 
> [...]
> 
> @@ -119,5 +114,5 @@
>      CODEC_ID_NONE,
>      adts_write_header,
>      adts_write_packet,
> -    adts_write_trailer,
> +    NULL,
>  };

The NULL here is absolutely useless. IMHO, you should simply remove the
write_trailer line (here and everywhere else in your patch).

Aurel