[FFmpeg-devel] [PATCH/DRAFT] MonkeyAudio Demuxer/Decoder

[Michael Niedermayer]

Hi

On Mon, Jun 25, 2007 at 02:59:31PM +0300, Kostya wrote:
[...]
> [...] 
> > > > +
> > > > +static inline void vector_add (int16_t* v1, int16_t* v2, int order)
> > > > +{
> > > > +  int or = 1;
> > > > +  if (order > 32)
> > > > +    or = (order >> 5);
> > > > +
> > > > +  while (or--)
> > > > +  {
> > > > +    int i;
> > > > +
> > > > +    for (i = 0; i < 16; i++)
> > > > +      *v1++ += *v2++;
> > > > +
> > > > +    if (order > 16)
> > > > +      for (i = 0; i < 16; i++)
> > > > +        *v1++ += *v2++;
> > > > +  }
> > > > +}
> > 
> > > and this whole function is just
> > > for (i = 0; i < order; i++)
> > >     *v1++ += *v2++;
> > 
> > I've tested it and it's not :-(
> 
> it does this fixed number of times:
> order <= 16: 16 times;
> order <= 32: 32 times;
> order > 32: (order >> 5) * 32 times or order & ~31 times. 

this function isnt called with any order which is not a multiple of 16 
or at least i thouhght so when i wrote my suggestion about simplifying
it

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070625/fdfe9fa2/attachment.pgp>