[FFmpeg-devel] [PATCH] RoQ video encoder (take 4)

Benoit Fouet benoit.fouet
Mon Jun 25 14:09:35 CEST 2007


Vitor wrote:
> Hi
>
> Benoit Fouet wrote:
>> Vitor wrote:
>>> +static void gather_data_for_cel(cel_evaluation_t *cel, RoqContext
>>> *enc,
>>> +                                roq_tempdata_t *tempData)
>>> +{
>>>
>>> [snip]
>>>
>>> +    if (cel->best_coding == RoQ_ID_CCC)
>>> +        for (i=0; i<4; i++)
>>> +            if (cel->subCels[i].best_coding == RoQ_ID_SLD)
>>> +               
>>> tempData->codebooks.usedCB4[cel->subCels[i].cbEntry]++;
>>> +            else if (cel->subCels[i].best_coding == RoQ_ID_CCC)
>>> +                for (j=0; j<4; j++)
>>> +                   
>>> tempData->codebooks.usedCB2[cel->subCels[i].subCels[j]]++;
>>> +}
>>> +
>>
>> would it be possible to add braces here, or am i the only to wish it ?
>
> I have nothing against it, the else clause is a little bit ambiguous
> as is.
>

Thanks,

Applied (as already ok'ed by Michael)

Ben
-- 
Purple Labs S.A.
www.purplelabs.com




More information about the ffmpeg-devel mailing list